Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set INTERFACE_LINK_DIRECTORIES on caffe2::mkl #89359

Closed
wants to merge 1 commit into from

Commits on Nov 20, 2022

  1. Set INTERFACE_LINK_DIRECTORIES on caffe2::mkl

    This ensures that subsequent link commands involving mkl libraries
    know where to find the libraries if they are in a non-standard
    location (which is the case if you installed mkl via conda, which
    is what our standard instructions recommend.)
    
    This is kind of a hack, because the MKL libraries are not actually
    guaranteed to be in $MKL_ROOT/lib (they are for the conda install
    though).  The real fix is to properly use the MKL targets from
    FindMKL.cmake but thats its own can of fish.  See
    #73008
    
    This fixes pytorch/audio#2784
    
    Signed-off-by: Edward Z. Yang <ezyang@fb.com>
    
    [ghstack-poisoned]
    ezyang committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    0c2d960 View commit details
    Browse the repository at this point in the history