Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NumPy broadcasting in lstsq_backward #91460

Closed
wants to merge 2 commits into from
Closed

Fix NumPy broadcasting in lstsq_backward #91460

wants to merge 2 commits into from

Conversation

lezcano
Copy link
Collaborator

@lezcano lezcano commented Dec 28, 2022 •
edited by pytorch-bot bot

@lezcano lezcano mentioned this pull request Dec 28, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 28, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91460

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 1a8b9ca:

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lezcano added a commit that referenced this pull request Dec 28, 2022
@lezcano
Fix NumPy broadcasting in lstsq_backward
947b446 
Fixes #77225

ghstack-source-id: dfd18de322d93a5f9b3b6c51f1d31ebdb7d7df8d
Pull Request resolved: #91460
@lezcano lezcano added module: derivatives Related to derivatives of operators release notes: autograd release notes category labels Dec 29, 2022
@lezcano
Copy link
Collaborator Author

lezcano commented Dec 29, 2022

The errors in both PRs are unrelated.

albanD
albanD reviewed Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds ok to me

torch/csrc/autograd/FunctionsManual.cpp Outdated Show resolved Hide resolved
lezcano added a commit that referenced this pull request Dec 29, 2022
@lezcano
Fix NumPy broadcasting in lstsq_backward
98a5f51 
Fixes #77225

ghstack-source-id: b0f553a7df1351efff39d7d129279294ea956cec
Pull Request resolved: #91460
albanD
albanD approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@lezcano
Copy link
Collaborator Author

lezcano commented Dec 29, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@lezcano
Copy link
Collaborator Author

lezcano commented Dec 30, 2022

@pytorchbot merge -f "flakkkyyy"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 30, 2022

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@lezcano
Copy link
Collaborator Author

lezcano commented Dec 30, 2022

@pytorchbot merge -f "flaky tests"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/170/head branch June 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@albanD albanD albanD approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: derivatives Related to derivatives of operators open source release notes: autograd release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lezcano @pytorchmergebot @Skylion007 @albanD @pytorchbot