Fix gumbel cdf #91698

vfonov · 2023-01-04T14:35:55Z

Fix Gumbel.cdf function.

Description
When transformed parameters is outside of the support of underlying Uniform distribution. This makes behavior of Gumbel.cdf consistent with other TransformedDistribution that pass value of validate_args to the base distribution.

Issue
running Gumbel(0.0,1.0,validate_args=False).cdf(20.0) would cause ValueError exception from _validate_sample

Testing
Test was added to the test_distributions.py to check if Gumbel(0.0,1.0,validate_args=False).cdf(20.0) successfully returns 1.0

This is a second attempt to push changes , after #82488

cc @fritzo @neerajprad @alicanb @nikitaved

pytorch-bot · 2023-01-04T14:35:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91698

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5143a0f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fritzo

LGTM, thanks for fixing this!

fritzo · 2023-01-05T01:09:59Z

@zou3519 could you merge this please? I'm unsure of the current merge process

github-actions · 2023-03-06T02:06:04Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

zou3519 · 2023-03-07T16:19:06Z

Sorry, I was out of town for a while and just saw this now. Let me try to rebase (automatically first, then manually) and then I'll get this merged.

zou3519 · 2023-03-07T16:19:25Z

@pytorchbot help

pytorch-bot · 2023-03-07T16:19:27Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'help' (choose from 'merge', 'revert', 'rebase', 'label', 'drci')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

zou3519 · 2023-03-07T16:19:39Z

@pytorchbot rebase

pytorchmergebot · 2023-03-07T16:21:38Z

@pytorchbot successfully started a rebase job. Check the current status here

…pport of underlying Uniform distribution

pytorchmergebot · 2023-03-07T16:21:45Z

Successfully rebased fix_gumbel_cdf_mk2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_gumbel_cdf_mk2 && git pull --rebase)

zou3519 · 2023-03-07T22:59:01Z

@pytorchbot merge

pytorchmergebot · 2023-03-07T23:00:51Z

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

zou3519 · 2023-03-07T23:02:51Z

@pytorchbot merge

pytorchmergebot · 2023-03-07T23:04:41Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fix `Gumbel.cdf` function. **Description** When transformed parameters is outside of the support of underlying Uniform distribution. This makes behavior of `Gumbel.cdf` consistent with other `TransformedDistribution` that pass value of validate_args to the base distribution. **Issue** running `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` would cause `ValueError` exception from `_validate_sample` **Testing** Test was added to the `test_distributions.py` to check if `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` successfully returns `1.0` This is a second attempt to push changes , after pytorch#82488 Pull Request resolved: pytorch#91698 Approved by: https://github.com/fritzo, https://github.com/zou3519

Fix `Gumbel.cdf` function. **Description** When transformed parameters is outside of the support of underlying Uniform distribution. This makes behavior of `Gumbel.cdf` consistent with other `TransformedDistribution` that pass value of validate_args to the base distribution. **Issue** running `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` would cause `ValueError` exception from `_validate_sample` **Testing** Test was added to the `test_distributions.py` to check if `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` successfully returns `1.0` This is a second attempt to push changes , after pytorch/pytorch#82488 Pull Request resolved: pytorch/pytorch#91698 Approved by: https://github.com/fritzo, https://github.com/zou3519

Fix `Gumbel.cdf` function. **Description** When transformed parameters is outside of the support of underlying Uniform distribution. This makes behavior of `Gumbel.cdf` consistent with other `TransformedDistribution` that pass value of validate_args to the base distribution. **Issue** running `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` would cause `ValueError` exception from `_validate_sample` **Testing** Test was added to the `test_distributions.py` to check if `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` successfully returns `1.0` This is a second attempt to push changes , after pytorch#82488 Pull Request resolved: pytorch#91698 Approved by: https://github.com/fritzo, https://github.com/zou3519

pytorchbot added the open source label Jan 4, 2023

zou3519 added the module: distributions Related to torch.distributions label Jan 4, 2023

zou3519 requested a review from fritzo January 4, 2023 15:22

zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 4, 2023

fritzo approved these changes Jan 5, 2023

View reviewed changes

github-actions bot added the Stale label Mar 6, 2023

zou3519 removed the Stale label Mar 7, 2023

zou3519 approved these changes Mar 7, 2023

View reviewed changes

zou3519 self-assigned this Mar 7, 2023

vfonov added 4 commits March 7, 2023 16:21

Fix Gumbel.cdf function, when transformed parameters is outside of su…

4b2cb26

…pport of underlying Uniform distribution

Fixing linting errors

7ae541e

Fixing linting errors, added more spaces

5aaafe1

Fixed typo in the test

5143a0f

pytorchmergebot force-pushed the fix_gumbel_cdf_mk2 branch from 5e5c017 to 5143a0f Compare March 7, 2023 16:21

zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2023

zou3519 added the release notes: python_frontend release notes category label Mar 7, 2023

pytorchmergebot added the Merged label Mar 7, 2023

pytorchmergebot closed this in b0b5f3c Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix gumbel cdf #91698

Fix gumbel cdf #91698

vfonov commented Jan 4, 2023 •

edited by pytorch-bot bot

pytorch-bot bot commented Jan 4, 2023 •

edited

fritzo left a comment

fritzo commented Jan 5, 2023

github-actions bot commented Mar 6, 2023

zou3519 commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorch-bot bot commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

Fix gumbel cdf #91698

Fix gumbel cdf #91698

Conversation

vfonov commented Jan 4, 2023 • edited by pytorch-bot bot

pytorch-bot bot commented Jan 4, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91698

✅ No Failures

fritzo left a comment

Choose a reason for hiding this comment

fritzo commented Jan 5, 2023

github-actions bot commented Mar 6, 2023

zou3519 commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorch-bot bot commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

zou3519 commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

Merge failed

zou3519 commented Mar 7, 2023

pytorchmergebot commented Mar 7, 2023

Merge started

vfonov commented Jan 4, 2023 •

edited by pytorch-bot bot

pytorch-bot bot commented Jan 4, 2023 •

edited