Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Add aten::zero support #91731

Closed
wants to merge 4 commits into from
Closed

[ONNX] Add aten::zero support #91731

wants to merge 4 commits into from

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Jan 4, 2023 •
edited by pytorchmergebot

Stack from ghstack (oldest at bottom):

Fixes #90268

When we use tensor.zero_() with inplace slice, it actually uses aten::zero instead.

@titaiwangms
Add aten::zero support
63485de 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 4, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91731

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 119b716:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jan 4, 2023
titaiwangms added a commit that referenced this pull request Jan 4, 2023
@titaiwangms
Add aten::zero support
08ddfd8 
ghstack-source-id: cfa4997f1e23f06525566f9c5e46180a61a6c537
Pull Request resolved: #91731
@titaiwangms titaiwangms linked an issue Jan 4, 2023 that may be closed by this pull request
torch.onnx.errors.UnsupportedOperatorError: Exporting the operator 'aten::zero' to ONNX opset version 14 is not supported. #90268
Closed
@titaiwangms titaiwangms added module: onnx Related to torch.onnx topic: new features topic category labels Jan 4, 2023
BowenBao
BowenBao approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nit: "[ONNX]" in title

@titaiwangms titaiwangms changed the title Add aten::zero support [ONNX] Add aten::zero support Jan 5, 2023
@titaiwangms
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@titaiwangms
Update on "[ONNX] Add aten::zero support"
d055b5b 
Fixes #90268 

When we use `tensor.zero_()` with inplace slice, it actually uses `aten::zero` instead. 

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/AllenTiTaiWang/33/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/91731)

pytorchmergebot pushed a commit that referenced this pull request Jan 6, 2023
@titaiwangms
Add aten::zero support
40908ac 
ghstack-source-id: 03600a2f4f8f41123a46384528594687cbbdf6b7
Pull Request resolved: #91731
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated TestPublicBindings errors"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000
Copy link
Contributor

clee2000 commented Jan 6, 2023

@pytorchbot revert -m "failing test_correct_module_names https://hud.pytorch.org/pytorch/pytorch/commit/ff23508c0d491553dc8eea85fb45f49de52ca41f https://github.com/pytorch/pytorch/actions/runs/3859079162/jobs/6578419644" -c "ignoredsignal"

1 similar comment
@clee2000
Copy link
Contributor

clee2000 commented Jan 6, 2023

@pytorchbot revert -m "failing test_correct_module_names https://hud.pytorch.org/pytorch/pytorch/commit/ff23508c0d491553dc8eea85fb45f49de52ca41f https://github.com/pytorch/pytorch/actions/runs/3859079162/jobs/6578419644" -c "ignoredsignal"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@titaiwangms your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jan 6, 2023
@pytorchmergebot
Revert "[ONNX] Add aten::zero support (#91731)"
08a378a 
This reverts commit ff23508.

Reverted #91731 on behalf of https://github.com/clee2000 due to failing test_correct_module_names https://hud.pytorch.org/pytorch/pytorch/commit/ff23508c0d491553dc8eea85fb45f49de52ca41f https://github.com/pytorch/pytorch/actions/runs/3859079162/jobs/6578419644
@titaiwangms titaiwangms reopened this Jan 7, 2023
@BowenBao
Copy link
Collaborator

BowenBao commented Jan 7, 2023 

# torch.onnx.symbolic_opset9.zero:
  - Is NOT public: it is not inside the module's (`torch.onnx.symbolic_opset9`) `__all__`
  - Does look public: it does look public because it follows the rules from the doc above (does not start with `_` and has a proper `__module__`).
  - You can do either of these two things to fix this problem:
    - To make it public: add it from the modules's (`torch.onnx.symbolic_opset9`) `__all__`
    - To make it NOT look public: make its name start with `_`

@titaiwangms
Update on "[ONNX] Add aten::zero support"
3e4319a 
Fixes #90268 

When we use `tensor.zero_()` with inplace slice, it actually uses `aten::zero` instead. 

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request Jan 7, 2023
@titaiwangms
Add aten::zero support
baf9eeb 
ghstack-source-id: b52c24cce9168679da069f83cd65556ac189ece9
Pull Request resolved: #91731
@titaiwangms titaiwangms mentioned this pull request Jan 7, 2023
Closed
@titaiwangms
Update on "[ONNX] Add aten::zero support"
119b716 
Fixes #90268 

When we use `tensor.zero_()` with inplace slice, it actually uses `aten::zero` instead. 

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request Jan 7, 2023
@titaiwangms
Add aten::zero support
ed206ec 
ghstack-source-id: 3b15ee34ced4ccad7ad032b4ec04298f0b392c01
Pull Request resolved: #91731
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/AllenTiTaiWang/33/head branch June 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowenBao BowenBao BowenBao approved these changes

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes Reverted topic: new features topic category
Projects
None yet
Milestone
No milestone
5 participants
@titaiwangms @pytorchmergebot @clee2000 @BowenBao @pytorchbot