Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onnx] Add mse_loss symbolic #90717

Closed
wants to merge 3 commits into from
Closed

[onnx] Add mse_loss symbolic #90717

wants to merge 3 commits into from
+38 −0

Conversation

shubhambhokare1
Copy link
Collaborator

@shubhambhokare1 shubhambhokare1 commented Dec 12, 2022 •
edited

Adds support for mse_loss operator

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90717

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f480a5c:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Dec 12, 2022
@H-Huang H-Huang added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Dec 13, 2022
BowenBao
BowenBao approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you considered adding mse_loss as function in onnx?

@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/mse-loss branch 2 times, most recently from 6ef90d6 to 3fa39dc Compare January 5, 2023 19:47
@abock
Copy link
Contributor

abock commented Jan 5, 2023

@malfet these test failures look unrelated to this PR, as do the lintrunner failures. Any ideas?

@titaiwangms
Copy link
Collaborator

I think this one having the same issue as I did #91731 (comment)

@shubhambhokare1
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 3, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@shubhambhokare1
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abock abock abock approved these changes

@BowenBao BowenBao BowenBao approved these changes

@titaiwangms titaiwangms titaiwangms approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@shubhambhokare1 @abock @titaiwangms @pytorchmergebot @BowenBao @H-Huang @pytorchbot