Reduce some ambiguity in Tensor #92266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92266
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 961ec6f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D42538675 |
Skylion007
approved these changes
Jan 16, 2023
|
This pull request was exported from Phabricator. Differential Revision: D42538675 |
yinghai
pushed a commit
to yinghai/pytorch
that referenced
this pull request
Jan 17, 2023
Summary: Pull Request resolved: pytorch#92266 A lot of other libraries have their own `xyz::Tensor` data structure. Under some rare cases, when they interop with torch, there will be compilation error such as ``` torch/csrc/api/include/torch/data/samplers/random.h(49): error: "Tensor" is ambiguous ``` Making some of the `Tensor` namespace clear will resolve this. Test Plan: CI Differential Revision: D42538675 fbshipit-source-id: f9a65c5b180a5b1789ad1c90496ab7d980556c27
yinghai
force-pushed
the
export-D42538675
branch
from
7c0ff2f
to
d1a23ef
Compare
malfet
approved these changes
Jan 17, 2023
|
/easycla |
2 similar comments
|
/easycla |
|
/easycla |
|
This pull request was exported from Phabricator. Differential Revision: D42538675 |
yinghai
force-pushed
the
export-D42538675
branch
from
d1a23ef
to
a2a5d65
Compare
yinghai
pushed a commit
to yinghai/pytorch
that referenced
this pull request
Jan 17, 2023
Summary: Pull Request resolved: pytorch#92266 A lot of other libraries have their own `xyz::Tensor` data structure. Under some rare cases, when they interop with torch, there will be compilation error such as ``` torch/csrc/api/include/torch/data/samplers/random.h(49): error: "Tensor" is ambiguous ``` Making some of the `Tensor` namespace clear will resolve this. Test Plan: CI Reviewed By: malfet Differential Revision: D42538675 fbshipit-source-id: ea9599381c154b0bc1761cc9338cb3751a1e789b
|
This pull request was exported from Phabricator. Differential Revision: D42538675 |
yinghai
pushed a commit
to yinghai/pytorch
that referenced
this pull request
Jan 17, 2023
Summary: Pull Request resolved: pytorch#92266 A lot of other libraries have their own `xyz::Tensor` data structure. Under some rare cases, when they interop with torch, there will be compilation error such as ``` torch/csrc/api/include/torch/data/samplers/random.h(49): error: "Tensor" is ambiguous ``` Making some of the `Tensor` namespace clear will resolve this. ignore-github-export-checks Test Plan: CI Reviewed By: malfet Differential Revision: D42538675 fbshipit-source-id: 4194fa8cfa20b5d5cb4c4c14f921e7a27c526218
yinghai
force-pushed
the
export-D42538675
branch
from
a2a5d65
to
edf28f2
Compare
Summary: Pull Request resolved: pytorch#92266 A lot of other libraries have their own `xyz::Tensor` data structure. Under some rare cases, when they interop with torch, there will be compilation error such as ``` torch/csrc/api/include/torch/data/samplers/random.h(49): error: "Tensor" is ambiguous ``` Making some of the `Tensor` namespace clear will resolve this. ignore-github-export-checks Test Plan: CI Reviewed By: malfet Differential Revision: D42538675 fbshipit-source-id: 3bb47ad0d8e1d510f9e5d9a31b48ac3a2e257f9c
yinghai
force-pushed
the
export-D42538675
branch
from
edf28f2
to
961ec6f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42538675 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A lot of other libraries have their own
xyz::Tensordata structure. Under some rare cases, when they interop with torch, there will be compilation error such asMaking some of the
Tensornamespace clear will resolve this.Test Plan: CI
Differential Revision: D42538675