Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optim][nadam] group tensors in foreach, make it default #92715

Closed
wants to merge 1 commit into from
Closed

[optim][nadam] group tensors in foreach, make it default #92715

wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 20, 2023 •
edited

@janeyx99 janeyx99 requested a review from albanD as a code owner January 20, 2023 22:50
@janeyx99 janeyx99 mentioned this pull request Jan 20, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Jan 20, 2023
@janeyx99 janeyx99 mentioned this pull request Jan 20, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92715

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c8f0206:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Jan 20, 2023
@janeyx99
[optim][nadam] group tensors in foreach, make it default
7525ca6 
ghstack-source-id: d68de653aaab4815cbb44afdd45f4abedff53b94
Pull Request resolved: #92715
@janeyx99
Copy link
Contributor Author

@Skylion007 incorporated fast path in the util

@janeyx99 janeyx99 added ciflow/trunk Trigger trunk jobs on your pull request topic: bc breaking topic category labels Jan 21, 2023
albanD
albanD approved these changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/14/head branch June 8, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: bc breaking topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janeyx99 @pytorchmergebot @albanD