-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[functorch] fix batching rule for dropout #92975
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92975
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6acfa4c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #92283
The repro now works:
NOTE:
native_dropout_batching_rule(const Tensor& tensor, double p, c10::optional<bool> train)
was called only for CUDA tensor. Hence this issue only affected CUDA tensors and not CPU tensorsRef:
pytorch/aten/src/ATen/functorch/PyTorchOperatorHacks.cpp
Lines 251 to 258 in a6ac922