[nn] add set_to_none flag for C++ optim endpoint #92989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92989
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b74ccac: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added a commit
that referenced
this pull request
Jan 25, 2023
ghstack-source-id: 77afd5ad165d689e1919d8d7ab1a1143c5a7d6a6 Pull Request resolved: #92989
[ghstack-poisoned]
janeyx99
added a commit
that referenced
this pull request
Jan 25, 2023
ghstack-source-id: ca6e9ad746ce77e2d53f1e97b09371d3280eafd1 Pull Request resolved: #92989
ngimel
approved these changes
Jan 26, 2023
| if (p.grad().defined()) { | ||
| p.grad().detach_(); | ||
| p.grad().zero_(); | ||
| if (p.mutable_grad().defined()) { |
There was a problem hiding this comment.
why mutable_grad and not grad here?
There was a problem hiding this comment.
Because grad() comes up with an error when using reset that it is const.
The module.cpp zero_grad equivalent also uses mutable_grad().
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):