Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for none for NNModuleVariable.__module__ #93326

Closed

Conversation

tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Jan 31, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93326

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fd4a998:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42869182

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42869182

tugsbayasgalan added a commit to tugsbayasgalan/pytorch that referenced this pull request Jan 31, 2023
Summary: Pull Request resolved: pytorch#93326

Test Plan: CI

Differential Revision: D42869182

fbshipit-source-id: 153788f46f6b504ee9c5d0623510d017f0789ed1
@tugsbayasgalan tugsbayasgalan force-pushed the export-D42869182 branch 2 times, most recently from ec65a13 to b92433a Compare January 31, 2023 13:23
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42869182

tugsbayasgalan added a commit to tugsbayasgalan/pytorch that referenced this pull request Jan 31, 2023
Summary: Pull Request resolved: pytorch#93326

Test Plan: CI

Differential Revision: D42869182

fbshipit-source-id: 5cb66d9cc269e129ad8580efe02773750260b6a9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42869182

tugsbayasgalan added a commit to tugsbayasgalan/pytorch that referenced this pull request Jan 31, 2023
Summary:
Pull Request resolved: pytorch#93326

Unblocks: "AttributeError: 'NoneType' object has no attribute 'startswith'"

Test Plan: CI

Differential Revision: D42869182

fbshipit-source-id: fcd120b1ade4cbeda926f97e399ebbd0a38135fc
@gmagogsfm
Copy link
Contributor

@pytorchbot merge -g -r master

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 31, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased export-D42869182 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout export-D42869182 && git pull --rebase)

pytorchmergebot pushed a commit to tugsbayasgalan/pytorch that referenced this pull request Jan 31, 2023
Summary:
Pull Request resolved: pytorch#93326

Unblocks: "AttributeError: 'NoneType' object has no attribute 'startswith'"

Test Plan: CI

Differential Revision: D42869182

fbshipit-source-id: fcd120b1ade4cbeda926f97e399ebbd0a38135fc
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

Summary:
Pull Request resolved: pytorch#93326

Unblocks: "AttributeError: 'NoneType' object has no attribute 'startswith'"

Test Plan: CI

Reviewed By: suo

Differential Revision: D42869182

fbshipit-source-id: 6cc8ce44c4fb038123c539bd8c91fbe32731b8d0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42869182

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ragulpr added a commit to ragulpr/pytorch that referenced this pull request Feb 2, 2023
…n-dev-setup

* origin: (898 commits)
  Move dynamo.optimizations.distributed to backends (pytorch#93408)
  Remove cuda 11.6 from nightly (pytorch#93979)
  Refactor dynamo register_backend/BACKENDS (pytorch#93389)
  Remove cuda 11.6 from CI replace with 11.7 (pytorch#93406)
  [Dynamo] Rename `GuardBuilder.guarded_code` -> `check_fn_manager` (pytorch#93934)
  Revert "Remove CUDA 11.6 from nightly builds (pytorch#93404)"
  Revert "[inductor] fix crash issue when input is a view tensor (pytorch#90150)"
  Basic Validation for FSDP `state_dict` transformations of modules with persistent buffers (pytorch#93396)
  Merge Inductor perf smoke test with other inductor CI tests (pytorch#93395)
  [inductor] Don't import torchvision (pytorch#93027)
  [FSDP][3/N] Refactor `summon_full_params` unit tests (pytorch#92298)
  [FSDP][2/N] `_summon_full_params` -> `_unshard_params` (pytorch#92297)
  Remove CUDA 11.6 from nightly builds (pytorch#93404)
  Mark buffers that reuse other buffers (pytorch#93329)
  Refactor to allow reuse of SchedulerNode.allocate (pytorch#93328)
  retire sparse_mask_helper (pytorch#91714)
  update fbgemm third party (pytorch#93907)
  [inductor] fix crash issue when input is a view tensor (pytorch#90150)
  [Inductor] add config for weight prepacking (pytorch#93811)
  Check for none for NNModuleVariable.__module__ (pytorch#93326)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants