[Inductor] add config for weight prepacking #93811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93811
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 90cce21: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jgong5
requested changes
Feb 1, 2023
jgong5
approved these changes
Feb 1, 2023
torch/_inductor/config.py
Outdated
| @@ -78,6 +78,9 @@ | |||
|
|
|||
| comment_origin = False | |||
|
|
|||
| # enable mkldnn weight prepacking to get a better performance; may lead to large memory cost | |||
There was a problem hiding this comment.
Suggested change
| # enable mkldnn weight prepacking to get a better performance; may lead to large memory cost | |
| # enable mkldnn weight prepacking to get a better performance; may lead to large memory footprint |
Valentine233
force-pushed
the
weight_prepack_config
branch
from
33afa67
to
5a8bca0
Compare
Chillee
reviewed
Feb 1, 2023
@Chillee The topic is mentioned by Jiong above. As the weight prepack happens outside cpp codegen, it may not be proper to move it under the cpp section. |
|
But it's only relevant for CPU codegen, no? |
Yes. I'm fine it is kept inside cpp section. |
Valentine233
force-pushed
the
weight_prepack_config
branch
from
5a8bca0
to
90cce21
Compare
@Chillee OK, changed. |
jansel
approved these changes
Feb 2, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ragulpr
added a commit
to ragulpr/pytorch
that referenced
this pull request
Feb 2, 2023
…n-dev-setup * origin: (898 commits) Move dynamo.optimizations.distributed to backends (pytorch#93408) Remove cuda 11.6 from nightly (pytorch#93979) Refactor dynamo register_backend/BACKENDS (pytorch#93389) Remove cuda 11.6 from CI replace with 11.7 (pytorch#93406) [Dynamo] Rename `GuardBuilder.guarded_code` -> `check_fn_manager` (pytorch#93934) Revert "Remove CUDA 11.6 from nightly builds (pytorch#93404)" Revert "[inductor] fix crash issue when input is a view tensor (pytorch#90150)" Basic Validation for FSDP `state_dict` transformations of modules with persistent buffers (pytorch#93396) Merge Inductor perf smoke test with other inductor CI tests (pytorch#93395) [inductor] Don't import torchvision (pytorch#93027) [FSDP][3/N] Refactor `summon_full_params` unit tests (pytorch#92298) [FSDP][2/N] `_summon_full_params` -> `_unshard_params` (pytorch#92297) Remove CUDA 11.6 from nightly builds (pytorch#93404) Mark buffers that reuse other buffers (pytorch#93329) Refactor to allow reuse of SchedulerNode.allocate (pytorch#93328) retire sparse_mask_helper (pytorch#91714) update fbgemm third party (pytorch#93907) [inductor] fix crash issue when input is a view tensor (pytorch#90150) [Inductor] add config for weight prepacking (pytorch#93811) Check for none for NNModuleVariable.__module__ (pytorch#93326) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93495
Mkldnn weight prepacking may lead to large memory footprint for some models such as UniXcoder. In this case, disabling mkldnn weight prepacking is needed to avoid memory overload.
This PR adds a config for switching mkldnn weight prepacking.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @ezyang @soumith @msaroufim @wconstab @ngimel @bdhirsh @mlazos @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @Guobing-Chen @chunyuan-w @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire