Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functorch] roll : fix batching rule for scalar tensor #95048

Closed
wants to merge 1 commit into from
Closed

[functorch] roll : fix batching rule for scalar tensor #95048

wants to merge 1 commit into from

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Feb 17, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95048

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ef45e74:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kshitij12345 kshitij12345 marked this pull request as ready for review February 17, 2023 10:43
@dagitses dagitses added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: functorch Pertaining to torch.func or pytorch/functorch labels Feb 17, 2023
@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 19, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "[functorch] roll : fix batching rule for scalar tensor (pytor…
e498863 
…ch#95048)"

This reverts commit 06489a3.
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@kshitij12345 @jhavukainen
[functorch] roll : fix batching rule for scalar tensor (pytorch#95048)
0e0f368 
Fixes pytorch#94925

Pull Request resolved: pytorch#95048
Approved by: https://github.com/Skylion007, https://github.com/ngimel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@ngimel ngimel ngimel approved these changes

@Chillee Chillee Awaiting requested review from Chillee

@mruberry mruberry Awaiting requested review from mruberry

Assignees

@Chillee Chillee

Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: functorch Pertaining to torch.func or pytorch/functorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jacrev and jacfwd fail for torch.roll when input is a scalar
7 participants
@kshitij12345 @pytorchmergebot @Skylion007 @ngimel @dagitses @Chillee @pytorchbot