[MPS] Convolution cleanup; remove unnecessary contiguous calls #95078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DenisVieriu97
commented
Feb 17, 2023
DenisVieriu97
commented
- Fixes convolution crashes in backward with weights
- Removes unnecessary contiguous calls
…ntiguous calls (#341) * Fix convolution crash; remove unnecessary contiguous calls * Fix lintrunner
kulinseth
approved these changes
Feb 17, 2023
kulinseth
requested changes
Feb 18, 2023
Co-authored-by: Ramin Azarmehr <razarmehr@apple.com>
kulinseth
approved these changes
Feb 22, 2023
|
@pytorchbot merge -f "MPS tests are green." |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Feb 22, 2023
…ch#95078) - Fixes convolution crashes in backward with weights - Removes unnecessary contiguous calls Pull Request resolved: pytorch#95078 Approved by: https://github.com/kulinseth
This was referenced Feb 22, 2023
atalman
pushed a commit
that referenced
this pull request
Feb 23, 2023
* [MPS] Convolution cleanup; remove unnecessary contiguous calls (#95078) - Fixes convolution crashes in backward with weights - Removes unnecessary contiguous calls Pull Request resolved: #95078 Approved by: https://github.com/kulinseth * [MPS] Fix nn.functional.conv_transpose2d grad (#94871) - add _mps_convolution_impl that takes optional shape - for conv_tranpose2d grad, use the shape from forward pass directly - for conv, calculate the shape from input - remove nn.functional.conv_transpose2d grad from blocklist Pull Request resolved: #94871 Approved by: https://github.com/kulinseth --------- Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com> Co-authored-by: Denis Vieriu <dvieriu@apple.com>
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
- Fixes convolution crashes in backward with weights - Removes unnecessary contiguous calls Pull Request resolved: pytorch/pytorch#95078 Approved by: https://github.com/kulinseth
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
pytorch#95078)" This reverts commit 5e47571.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
* [MPS] Convolution cleanup; remove unnecessary contiguous calls (pytorch#95078) - Fixes convolution crashes in backward with weights - Removes unnecessary contiguous calls Pull Request resolved: pytorch#95078 Approved by: https://github.com/kulinseth * [MPS] Fix nn.functional.conv_transpose2d grad (pytorch#94871) - add _mps_convolution_impl that takes optional shape - for conv_tranpose2d grad, use the shape from forward pass directly - for conv, calculate the shape from input - remove nn.functional.conv_transpose2d grad from blocklist Pull Request resolved: pytorch#94871 Approved by: https://github.com/kulinseth --------- Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com> Co-authored-by: Denis Vieriu <dvieriu@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.