Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle int/float arguments for cpp codegen in inductor #95533

Closed
wants to merge 6 commits into from
Closed

Handle int/float arguments for cpp codegen in inductor #95533

wants to merge 6 commits into from
+62 −12

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Feb 25, 2023 •
edited

Stack from ghstack (oldest at bottom):

This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@ezyang
Handle int/float arguments for cpp codegen in inductor
f510cd1 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Feb 25, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 25, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95533

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 0d61afb:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Feb 25, 2023
@ezyang
Handle int/float arguments for cpp codegen in inductor
aba2c44 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: f665d9b8370c2aaccd59df01d16276d8eeb09093
Pull Request resolved: #95533
@ezyang
Update on "Handle int/float arguments for cpp codegen in inductor"
0ea22ed 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Feb 25, 2023
@ezyang
Handle int/float arguments for cpp codegen in inductor
5960589 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 6e1bd94fa815772c6af3e65347278643e700a923
Pull Request resolved: #95533
@ezyang ezyang requested review from ngimel and jansel February 25, 2023 02:19
@ezyang ezyang mentioned this pull request Feb 25, 2023
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Feb 27, 2023

@Chillee I'm stealing some changes from #93059 into this PR

@ezyang
Update on "Handle int/float arguments for cpp codegen in inductor"
16cb086 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Feb 27, 2023
@ezyang
Handle int/float arguments for cpp codegen in inductor
8f5aa05 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 4b69e5c60b98b2b3dbebd863c619e29bf6d0e161
Pull Request resolved: #95533
@ezyang ezyang added the topic: bug fixes topic category label Feb 27, 2023
@ezyang ezyang mentioned this pull request Feb 27, 2023
Closed
@ezyang
Update on "Handle int/float arguments for cpp codegen in inductor"
1db9116 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@ezyang
Update on "Handle int/float arguments for cpp codegen in inductor"
b945d6a 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@ezyang
Update on "Handle int/float arguments for cpp codegen in inductor"
0d61afb 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Feb 28, 2023

@pytorchbot merge -f "distributed timeout"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
@ezyang @cyyever
Handle int/float arguments for cpp codegen in inductor (#95533)
73310e9 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch/pytorch#95533
Approved by: https://github.com/ngimel, https://github.com/jansel
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@ezyang @cyyever
Handle int/float arguments for cpp codegen in inductor (#95533)
42dca88 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch/pytorch#95533
Approved by: https://github.com/ngimel, https://github.com/jansel
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@ezyang @cyyever
Handle int/float arguments for cpp codegen in inductor (#95533)
f3227cc 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch/pytorch#95533
Approved by: https://github.com/ngimel, https://github.com/jansel
@ezyang ezyang added this to the 2.0.1 milestone Mar 20, 2023
@ezyang ezyang mentioned this pull request Mar 22, 2023
Closed
@ezyang ezyang removed this from the 2.0.1 milestone Apr 21, 2023
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "Handle int/float arguments for cpp codegen in inductor (pytor…
f819460 
…ch#95533)"

This reverts commit 5864882.
@chunyuan-w chunyuan-w mentioned this pull request May 12, 2023
Closed
chunyuan-w added a commit that referenced this pull request May 12, 2023
@chunyuan-w
Update on "Inductor cpp wrapper: support sympy.Expr as input"
0168162 
Leverage the logic in #95533 to get the `dtype` of `sympy.Expr` and extract the logic into a utility function.


cc soumith voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request May 14, 2023
@chunyuan-w
Update on "Inductor cpp wrapper: support sympy.Expr as input"
ca347f3 
Leverage the logic in #95533 to get the `dtype` of `sympy.Expr` and support it as graph input in the cpp wrapper.


cc soumith voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request May 15, 2023
@chunyuan-w
Update on "Inductor cpp wrapper: support sympy.Expr as input"
fa8f452 
Leverage the logic in #95533 to get the `dtype` of `sympy.Expr` and support it as graph input in the cpp wrapper.


cc soumith voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request May 15, 2023
@chunyuan-w
Update on "Inductor cpp wrapper: support sympy.Expr as input"
75785a5 
Leverage the logic in #95533 to get the `dtype` of `sympy.Expr` and support it as graph input in the cpp wrapper.


cc soumith voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request May 15, 2023
@chunyuan-w @pytorchmergebot
Inductor cpp wrapper: support sympy.Expr as input (#101257)
1faef89 
Leverage the logic in #95533 to get the `dtype` of `sympy.Expr` and support it as graph input in the cpp wrapper.

Pull Request resolved: #101257
Approved by: https://github.com/jgong5, https://github.com/Skylion007, https://github.com/EikanWang, https://github.com/jansel
jcaip pushed a commit that referenced this pull request May 23, 2023
@chunyuan-w @jcaip
Inductor cpp wrapper: support sympy.Expr as input (#101257)
fecd91e 
Leverage the logic in #95533 to get the `dtype` of `sympy.Expr` and support it as graph input in the cpp wrapper.

Pull Request resolved: #101257
Approved by: https://github.com/jgong5, https://github.com/Skylion007, https://github.com/EikanWang, https://github.com/jansel
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1852/head branch June 8, 2023 16:52
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@ezyang @jhavukainen
Handle int/float arguments for cpp codegen in inductor (pytorch#95533)
02e95b4 
This is a little questionable because we don't actually know what the dtype of the sympy expression is, and it's not clear we can rely on the assumptions.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#95533
Approved by: https://github.com/ngimel, https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@ngimel ngimel ngimel approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor Merged module: inductor release notes: AO frontend topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ezyang @pytorchmergebot @jansel @ngimel