[BE] Fix TORCH_WARN_ONCE #95559
Closed
[BE] Fix TORCH_WARN_ONCE #95559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not take a condition as first argument, unlike `TORCH_CHECK`
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95559
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 28719a3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
Skylion007
approved these changes
Feb 25, 2023
|
@pytorchbot merge -f "MPS tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Yeah, it should be opposite. |
@malfet can this be cherry-picked to release 2.0? It will create spurious warnings |
malfet
added a commit
that referenced
this pull request
Mar 1, 2023
It does not take a condition as first argument, unlike `TORCH_CHECK` Test plan, run: ` python3 -c "import torch;print(torch.arange(1., 10.,device='mps').view(3, 3).trace())"` and observe no warning Pull Request resolved: #95559 Approved by: https://github.com/Skylion007 (cherry picked from commit 9bca9df)
atalman
pushed a commit
that referenced
this pull request
Mar 2, 2023
It does not take a condition as first argument, unlike `TORCH_CHECK` Test plan, run: ` python3 -c "import torch;print(torch.arange(1., 10.,device='mps').view(3, 3).trace())"` and observe no warning Pull Request resolved: #95559 Approved by: https://github.com/Skylion007 (cherry picked from commit 9bca9df)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
It does not take a condition as first argument, unlike `TORCH_CHECK` Test plan, run: ` python3 -c "import torch;print(torch.arange(1., 10.,device='mps').view(3, 3).trace())"` and observe no warning Pull Request resolved: pytorch/pytorch#95559 Approved by: https://github.com/Skylion007
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit 9bca9df.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
It does not take a condition as first argument, unlike `TORCH_CHECK` Test plan, run: ` python3 -c "import torch;print(torch.arange(1., 10.,device='mps').view(3, 3).trace())"` and observe no warning Pull Request resolved: pytorch#95559 Approved by: https://github.com/Skylion007 (cherry picked from commit 9bca9df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not take a condition as first argument, unlike
TORCH_CHECKTest plan, run:
python3 -c "import torch;print(torch.arange(1., 10.,device='mps').view(3, 3).trace())"and observe no warning