Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maxint to bound integers. #96121

Closed
wants to merge 4 commits into from
Closed

Use maxint to bound integers. #96121

wants to merge 4 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Mar 6, 2023 •
edited

Stack from ghstack (oldest at bottom):

We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang ezyang@meta.com

@ezyang
Use maxint to bound integers.
40d95bc 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Mar 6, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 6, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96121

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 57e2d32:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Mar 6, 2023
@ezyang
Use maxint to bound integers.
8bc5c86 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 0d97be5eab9c2ff74e64e9c799f5a491777a0482
Pull Request resolved: #96121
@ezyang
Update on "Use maxint to bound integers."
d7df13d 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Mar 6, 2023
@ezyang
Use maxint to bound integers.
f2c750c 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: cefcf018e6c1fcebc48b1678142711ce09596465
Pull Request resolved: #96121
eellison
eellison reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue with the previous code ?

@eellison
Copy link
Contributor

eellison commented Mar 6, 2023

Could we remove guards that check for INT_MAX instead ? it's not obvious from the code why we wouldn't be using ValueRanges.Unknown()

@ezyang
Copy link
Contributor Author

ezyang commented Mar 6, 2023

Yes i plan to do this.

@ezyang
Copy link
Contributor Author

ezyang commented Mar 6, 2023

Elias I will post the test case for this; the problem is we have some code testing for int_max

@ezyang
Update on "Use maxint to bound integers."
a46aeb5 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Mar 7, 2023
@ezyang
Use maxint to bound integers.
426df34 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c3589d3b055eef89470648814b238ccff4098067
Pull Request resolved: #96121
@ezyang
Copy link
Contributor Author

ezyang commented Mar 7, 2023

@eellison test case at https://github.com/pytorch/pytorch/pull/96121/files#diff-83343b7ad365ac39feaa074a66ca509cffc0d487f694ee724294c41b5569f321R973

@ezyang
Copy link
Contributor Author

ezyang commented Mar 7, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Update on "Use maxint to bound integers."
57e2d32 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Mar 7, 2023
@ezyang
Use maxint to bound integers.
3428e00 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 8b18d4ef39ff66862d6288f66d645dd495c8bf1b
Pull Request resolved: #96121
@ezyang
Copy link
Contributor Author

ezyang commented Mar 7, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-bionic-cuda11.8-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Mar 7, 2023

@pytorchbot merge -f "unrelated timeout"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ydwu4 pushed a commit to ydwu4/pytorch that referenced this pull request Mar 10, 2023
@ezyang @ydwu4
Use maxint to bound integers. (pytorch#96121)
8354499 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch#96121
Approved by: https://github.com/tugsbayasgalan, https://github.com/lezcano
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@ezyang @cyyever
Use maxint to bound integers. (#96121)
c9f39a8 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch/pytorch#96121
Approved by: https://github.com/tugsbayasgalan, https://github.com/lezcano
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@ezyang @cyyever
Use maxint to bound integers. (#96121)
bcc9a31 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch/pytorch#96121
Approved by: https://github.com/tugsbayasgalan, https://github.com/lezcano
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
Use maxint to bound integers. (pytorch#96121)
d8f8032 
We don't actually support arbitrary precision integers.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch#96121
Approved by: https://github.com/tugsbayasgalan, https://github.com/lezcano
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1885/head branch June 8, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison left review comments

@lezcano lezcano lezcano approved these changes

@tugsbayasgalan tugsbayasgalan tugsbayasgalan approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@nunoplopes nunoplopes Awaiting requested review from nunoplopes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ezyang @eellison @pytorchmergebot @lezcano @tugsbayasgalan