Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maxint to bound integers. #96121

Closed
wants to merge 4 commits into from
Closed

Use maxint to bound integers. #96121

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40d95bc
Use maxint to bound integers.
ezyang Mar 6, 2023
d7df13d
Update on "Use maxint to bound integers."
ezyang Mar 6, 2023
a46aeb5
Update on "Use maxint to bound integers."
ezyang Mar 7, 2023
57e2d32
Update on "Use maxint to bound integers."
ezyang Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions torch/fx/experimental/symbolic_shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,7 @@ def create_unbacked_symfloat(self):
def create_unbacked_symint(self):
symbol = sympy.Symbol(f"i{next(self.unbacked_symint_counter)}", integer=True)
self.var_to_stack[symbol] = ''.join(traceback.format_list(traceback.extract_stack()[:-1]))
self.var_to_range[symbol] = ValueRanges.unknown()
self.var_to_range[symbol] = ValueRanges(-sys.maxsize - 1, sys.maxsize)
return SymInt(SymNode(symbol, self, int, None))

# This is guaranteed to return a symbol or its negation is a sympy.Symbol,
Expand All @@ -1361,7 +1361,10 @@ def create_symbol(self, val: int, source: Source, dyn=False) -> "sympy.Expr":

# We also infer that it must be not 0/1
lower = 2 if self.specialize_zero_one else 0
self.var_to_range[sympy_expr] = ValueRanges(lower, sympy.oo)
# NB: sys.maxsize is NOT allowed for sizes, because we use MAX_INT
# as a sentinel sometimes. Your sizevar isn't going to be
# anywhere near the max 64-bit integer anyway.
self.var_to_range[sympy_expr] = ValueRanges(lower, sys.maxsize - 1)

if not dyn and self.duck_shape:
# This implements duck-shaping: input sizes that match are assigned
Expand Down