Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying device_option in Functional #9619

Closed
wants to merge 2 commits into from
Closed

Add support for specifying device_option in Functional #9619

wants to merge 2 commits into from

Conversation

bddppq
Copy link
Contributor

@bddppq bddppq commented Jul 20, 2018 •
edited
Loading

e.g.

Functional.Add(x, y, device_option=DeviceOption(HIP, 0))

@bddppq bddppq requested a review from jerryzh168 July 20, 2018 06:52
jerryzh168
jerryzh168 approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add some tests as well so that people know how to use it..

@bddppq
Copy link
Contributor Author

bddppq commented Jul 20, 2018

@jerryzh168 good point, I will add some test cases.

facebook-github-bot
facebook-github-bot reviewed Jul 24, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zou3519 zou3519 added the caffe2 label Jul 24, 2018
@bddppq
Copy link
Contributor Author

bddppq commented Jul 24, 2018

@pytorchbot retest this please

@bddppq bddppq deleted the functional-device-option branch July 24, 2018 21:53
jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
@bddppq @jramseyer
Add support for specifying device_option in Functional (pytorch#9619)
d7833a8 
Summary:
e.g.
```
Functional.Add(x, y, device_option=DeviceOption(HIP, 0))

```
Pull Request resolved: pytorch#9619

Differential Revision: D8966599

Pulled By: bddppq

fbshipit-source-id: 22235e42f19278e79802642798bf0ee70a1202f6
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@bddppq
Add support for specifying device_option in Functional (pytorch#9619)
03f8ae8 
Summary:
e.g.
```
Functional.Add(x, y, device_option=DeviceOption(HIP, 0))

```
Pull Request resolved: pytorch#9619

Differential Revision: D8966599

Pulled By: bddppq

fbshipit-source-id: 22235e42f19278e79802642798bf0ee70a1202f6
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
caffe2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bddppq @jerryzh168 @facebook-github-bot @ezyang @zou3519