Enable fused optimizer for DP #98270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin and
kiukchung
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98270
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6a114e6: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (c10d)
rohan-varma
added a commit
that referenced
this pull request
Apr 4, 2023
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! ghstack-source-id: 184956702 Pull Request resolved: #98270
awgu
approved these changes
Apr 4, 2023
| @@ -1464,9 +1464,9 @@ void Reducer::finalize_bucket_dense(Bucket& bucket) { | |||
| } | |||
|
|
|||
| if (!gradient_as_bucket_view_) { | |||
| if (set_grads_to_none_) { | |||
| if (optim_in_backward_) { | |||
| // Return early has optimizer has already run. | |||
There was a problem hiding this comment.
nit: Maybe typo?
Suggested change
| // Return early has optimizer has already run. | |
| // Return early since optimizer has already run. |
| if (set_grads_to_none_) { | ||
| grad.reset(); | ||
| if (optim_in_backward_) { | ||
| // Return early has optimizer has already run. |
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 11, 2023
Pull Request resolved: #98270 Enable DDP optimizer overlap for HPC 10x CMF, providing ~7% QPS gain. ghstack-source-id: 185743906 Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)!
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 11, 2023
Pull Request resolved: #98270 Enable DDP optimizer overlap for HPC 10x CMF, providing ~7% QPS gain. ghstack-source-id: 185745827 Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)!
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 12, 2023
Pull Request resolved: #98270 Enable DDP optimizer overlap for HPC 10x CMF, providing ~7% QPS gain. ghstack-source-id: 185811936 Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)!
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 12, 2023
Pull Request resolved: #98270 Enable DDP optimizer overlap for HPC 10x CMF, providing ~7% QPS gain. ghstack-source-id: 185866613 Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)!
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 12, 2023
Pull Request resolved: #98270 Enable DDP optimizer overlap for HPC 10x CMF, providing ~7% QPS gain. ghstack-source-id: 185879423 Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)!
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
Differential Revision: [D42714482](https://our.internmc.facebook.com/intern/diff/D42714482/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D42714482/)! Pull Request resolved: #98270 Approved by: https://github.com/awgu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D42714482
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!