-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fused optimizer for DP #98270
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f3fa33a
Enable fused optimizer for DP
rohan-varma 4e4bf3f
Update on "Enable fused optimizer for DP"
rohan-varma 80d9625
Update on "Enable fused optimizer for DP"
rohan-varma 8e40ae5
Update on "Enable fused optimizer for DP"
rohan-varma 0b45637
Update on "Enable fused optimizer for DP"
rohan-varma 6a114e6
Update on "Enable fused optimizer for DP"
rohan-varma File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1464,9 +1464,9 @@ void Reducer::finalize_bucket_dense(Bucket& bucket) { | |
} | ||
|
||
if (!gradient_as_bucket_view_) { | ||
if (set_grads_to_none_) { | ||
if (optim_in_backward_) { | ||
// Return early has optimizer has already run. | ||
runGradCallbackForVariable(variable, [&](auto& grad) { | ||
grad.reset(); | ||
return true; | ||
}); | ||
} else { | ||
|
@@ -1486,8 +1486,8 @@ void Reducer::finalize_bucket_dense(Bucket& bucket) { | |
bucket_view_in.copy_(bucket_view_out); | ||
} | ||
runGradCallbackForVariable(variable, [&](auto& grad) { | ||
if (set_grads_to_none_) { | ||
grad.reset(); | ||
if (optim_in_backward_) { | ||
// Return early has optimizer has already run. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above: maybe typo? |
||
return true; | ||
} | ||
// If a parameter is globally unused, we keep its grad untouched. | ||
|
@@ -1806,10 +1806,6 @@ void Reducer::register_builtin_comm_hook( | |
} | ||
} | ||
|
||
void Reducer::set_grads_to_none(bool set_to_none) { | ||
set_grads_to_none_ = set_to_none; | ||
} | ||
|
||
void Reducer::ensure_prior_reduction_finished() { | ||
// Check that any prior reduction has finished. | ||
// The variable `require_finalize_` is true until all gradients | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe typo?