[FSDP] Clarify CPU offload implicitly in reshard_doc #98666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per title Differential Revision: [D44812344](https://our.internmc.facebook.com/intern/diff/D44812344/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98666
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5abb754: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
awgu
approved these changes
Apr 8, 2023
torch/distributed/fsdp/flat_param.py
Outdated
| sharded flat parameter. | ||
| sharded flat parameter. Note that this also implicitly offloads | ||
| the sharded flat parameter (if CPU offload is enabled) by pointing | ||
| it to the local_shard attribute which resides on CPU. |
There was a problem hiding this comment.
nit: Should we specify _local_shard with the prefixed underscore? (backticks do not matter much can be can do ``_local_shard`` for consistency)
Per title Differential Revision: [D44812344](https://our.internmc.facebook.com/intern/diff/D44812344/) [ghstack-poisoned]
|
@pytorchbot merge -f "Doc only" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
Per title Differential Revision: [D44812344](https://our.internmc.facebook.com/intern/diff/D44812344/) Pull Request resolved: #98666 Approved by: https://github.com/awgu
vkallesh
pushed a commit
to amd/ZenDNN-pytorch
that referenced
this pull request
Jul 5, 2023
Pull Request resolved: pytorch/pytorch#98666 Per title ghstack-source-id: 185660099 Differential Revision: [D44812344](https://our.internmc.facebook.com/intern/diff/D44812344/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Per title
Differential Revision: D44812344