Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSDP] Clarify CPU offload implicitly in reshard_doc #98666

Closed
wants to merge 2 commits into from
Closed

[FSDP] Clarify CPU offload implicitly in reshard_doc #98666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf5662
[FSDP] Clarify CPU offload implicitly in reshard_doc
rohan-varma Apr 8, 2023
5abb754
Update on "[FSDP] Clarify CPU offload implicitly in reshard_doc"
rohan-varma Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion torch/distributed/fsdp/flat_param.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,7 +1487,9 @@ def reshard(self, free_unsharded_flat_param: bool):
"""
Runs the reshard logic. This includes freeing the unsharded flat
parameter if ``free_unsharded_flat_param`` and switching to using the
sharded flat parameter.
sharded flat parameter. Note that this also implicitly offloads
the sharded flat parameter (if CPU offload is enabled) by pointing
it to the ``_local_shard`` attribute which resides on CPU.
"""
# Switch to the sharded `FlatParameter` before freeing to prevent
# "use-after-free"-type bugs with external profiling tools, where for
Expand Down