Convert logging f-strings to use % format, part three #98704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does triple-quoted strings. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
ezyang
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98704
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d75cb26: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 9, 2023
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
voznesenskym
approved these changes
Apr 9, 2023
This does triple-quoted strings. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
albanD
approved these changes
Apr 10, 2023
This does triple-quoted strings. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
This does triple-quoted strings. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
This does triple-quoted strings. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #98704 Approved by: https://github.com/voznesenskym, https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This does triple-quoted strings.
Signed-off-by: Edward Z. Yang ezyang@meta.com