Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert logging f-strings to use % format, part five #98765

Closed
wants to merge 4 commits into from
Closed

Convert logging f-strings to use % format, part five #98765

wants to merge 4 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Apr 10, 2023 •
edited

@ezyang
Convert logging f-strings to use % format, part five
0285df1 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Apr 10, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 10, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98765

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit dd79af7:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Apr 10, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: mobile release notes category label Apr 10, 2023
ezyang added a commit that referenced this pull request Apr 10, 2023
@ezyang
Convert logging f-strings to use % format, part five
2a8d4bd 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c0381009ba3a5dc4eef04ff66ec8270dcfb07e15
Pull Request resolved: #98765
ezyang
ezyang commented Apr 10, 2023
View reviewed changes
torch/package/_importlib.py Outdated
@@ -63,7 +63,7 @@ def _calc___package__(globals):
if package is not None:
if spec is not None and package != spec.parent:
_warnings.warn( # noqa: G010
"__package__ != __spec__.parent " f"({package!r} != {spec.parent!r})",
"__package__ != __spec__.parent " f"({package!r} != {spec.parent!r})", # noqa: G004
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is copypaste from cpython, just suppress the lint

@albanD albanD removed their request for review April 10, 2023 18:58
@ezyang
Update on "Convert logging f-strings to use % format, part five"
41aaa7c 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@ezyang ezyang requested a review from albanD as a code owner April 10, 2023 19:31
ezyang added a commit that referenced this pull request Apr 10, 2023
@ezyang
Convert logging f-strings to use % format, part five
d9e920b 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 5cf031408faae1b1a9bdfe9d00b34ccd64f990ae
Pull Request resolved: #98765
@ezyang
Copy link
Contributor Author

ezyang commented Apr 10, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: PR 98704 is out of sync with the corresponding revision 3ddcce5 on branch origin/gh/ezyang/1981/orig that would be merged into master. This usually happens because there is a non ghstack change in the PR. Please sync them and try again (ex. make the changes on origin/gh/ezyang/1981/orig and run ghstack).

Details for Dev Infra team Raised by workflow job

@ezyang
Update on "Convert logging f-strings to use % format, part five"
580dc97 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 11, 2023
@ezyang
Convert logging f-strings to use % format, part five
c8ba8fe 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: ea0df229af061178f8f336644d477e93a4533cfd
Pull Request resolved: #98765
@ezyang
Copy link
Contributor Author

ezyang commented Apr 11, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Update on "Convert logging f-strings to use % format, part five"
dd79af7 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Apr 11, 2023

@pytorchbot merge -f "was all green, re-push was to move a lint fix to the correct commit on stack"

ezyang added a commit that referenced this pull request Apr 11, 2023
@ezyang
Convert logging f-strings to use % format, part five
24f7ebd 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: ea0df229af061178f8f336644d477e93a4533cfd
Pull Request resolved: #98765
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
@ezyang @ZainRizvi
Convert logging f-strings to use % format, part five (#98765)
0d0c438 
This does some annoying but simple cases by hand.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #98765
Approved by: https://github.com/wanchaol
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1981/head branch June 8, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged merging module: dynamo release notes: mobile release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezyang @pytorchmergebot @wanchaol