Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Squeeze last dimensions if possible for 5D (or bigger) reductions #99856

Closed
wants to merge 2 commits into from
Closed

[MPS] Squeeze last dimensions if possible for 5D (or bigger) reductions #99856

wants to merge 2 commits into from

Conversation

DenisVieriu97
Copy link
Collaborator

Summary of changes:

  • Reduction ops optimization - squeeze all dimensions after 4th dim if they are all 1
  • Disable type inference only for 1D unary ops

@DenisVieriu97
Squeeze last dimensions if possible for 5D (or bigger) reductions (#408)
ad4a8cd 
* Squeeze last dimensions if possible for 5D (or bigger) reductions

* Remove unnecessary code

* Disable type infernce only for 1D tensors in unary
@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Apr 24, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 24, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99856

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit b497efc:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Apr 24, 2023
@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 25, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -g

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 25, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Mac MPS / macos-13-py3-arm64-mps / test (default, 1, 1)

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge -f "MPS+lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@razarmehr razarmehr Awaiting requested review from razarmehr

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DenisVieriu97 @pytorchmergebot @kulinseth @pytorchbot