[Feature] Habitat integration #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
knowledge_base/HABITAT.md
Outdated
|
|
||
| See Habitat-Sim's [installation instructions](https://github.com/facebookresearch/habitat-sim#installation) for more details. | ||
|
|
||
| 3. **Install habitat-baselines**. |
There was a problem hiding this comment.
I wonder if habitat_baselines are needed for torchrl. It seems the main use case will be to create and wrap environments (which is what habitat-lab does) without the need to use the habitat-baselines trainers.
There was a problem hiding this comment.
Yes we probably don't need that, I can remove it
# Conflicts: # test/_utils_internal.py # torchrl/envs/libs/gym.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures compatibility with habitat