Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding M1 to Ci workflows #2934

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Adding M1 to Ci workflows #2934

merged 8 commits into from
Feb 9, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Feb 8, 2024

Description

Adding M1 compatibility to CI jobs.
Tested:
Regression test
Ci test

Issue #2555

TODO

Change python back 3.8 when this issue is resolved.

Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So assuming CI passes we should be good to go but not sure I quite follow why we use python 3.10 vs 3.8 just for M1

steps:
- name: Setup Python 3.8
- name: Setup Python for M1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why python 3.10? It'll make releasing the binaries a bit annoying if each platform requires a different python version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github macos-14 does not work with python setup less than 3.10 actions/setup-python#808

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading through that issue it seems like the issue was fixed, mind retriggering with 3.8

@msaroufim msaroufim self-requested a review February 8, 2024 23:44
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so assuming the macos-14 jobs pass we should be good to merge this, they are likely not a required check so watch out and don't add this to merge queue before confirming

I'd also add a TODO referencing actions/setup-python#808 in both CI jobs so we can remember to remove the python 3.10 stuff when ready

@udaij12 udaij12 added this pull request to the merge queue Feb 9, 2024
Merged via the queue into master with commit ac885ca Feb 9, 2024
15 checks passed
@msaroufim msaroufim deleted the M1_changes branch February 9, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants