Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torchserve M1 support detailed plan #2555

Open
5 of 10 tasks
msaroufim opened this issue Aug 30, 2023 · 4 comments
Open
5 of 10 tasks

Torchserve M1 support detailed plan #2555

msaroufim opened this issue Aug 30, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers m1

Comments

@msaroufim
Copy link
Member

msaroufim commented Aug 30, 2023

🚀 The feature

Update Jan 31 2024 - we should speed this up
PyTorch on MacOS x86 is being deprecated pytorch/pytorch#114602

Officially support torchserve on M1-M2 mac hardware. A bunch of people have asked for this, if you're interested please either upvote or volunteer to do this work, would be happy to review

We have 6 issues of people asking for M1 support m1

Motivation, pitch

I've seen a bunch of issues asking for this but we haven't managed to prioritize it yet so thought I'd highlight what needs to be done to support this. There's two components to this work, most of this work is parallelizable with the exception of the official release script so feel free to pick up an issue and work on it

Code changes

Build changes

  • Ensure ts_scripts/install_dependencies.py installs the right binaries for M1
  • Ensure setup.py works on M1
  • Ensure that conda binaries work with osx-arm64
  • Change our CI job to run tests on M1 and deprecate the x86 version (Not deprecated yet simply added M1 compatibility)
  • Ensure build scripts in binaries still work for M1 for both pip and conda
  • In our official-release.yaml github action we should deprecate pushing regular mac binaries and instead move to using ARM M1 binaries
  • Update our docker build scripts to also work with M1 Docker build on M1 fails #1363 (comment)

cc @agunapal @mreso @malfet

Alternatives

No response

Additional context

No response

@msaroufim msaroufim added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file m1 labels Aug 30, 2023
@msaroufim msaroufim changed the title Torchserve M1 support Torchserve M1 support detailed plan Aug 30, 2023
@Talbot3
Copy link

Talbot3 commented Feb 27, 2024

did it ok?i am waiting ....

@udaij12
Copy link
Collaborator

udaij12 commented Mar 15, 2024

Hi @Talbot3 What issues are you still facing?

@VladimirKadlec
Copy link

Hi, just FYI, ./build_image.sh builds a working docker image just fine on Macbook Air M2 running Asahi Linux (Ubuntu 23.10)

@Talbot3
Copy link

Talbot3 commented Mar 21, 2024

Hi @Talbot3 What issues are you still facing?

#1363
I just want check pytorch serve container on my device (mac m1) can run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers m1
Projects
None yet
Development

No branches or pull requests

4 participants