Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove BERT example #1402

Merged
merged 1 commit into from
Oct 6, 2021
Merged

remove BERT example #1402

merged 1 commit into from
Oct 6, 2021

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented Oct 6, 2021

The BERT example is based on experimental version of datasets which were removed in this PR (#1326). Hence they are no longer functional and It causes confusion for the users (#1401).

The fix is non-trivial. Hence we would like to remove this example. Going forward, we will provide complementary examples ones the pre-trained models are added to the repo.

Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would just make sure test failures aren't related to these changes before merging.

@parmeet parmeet merged commit 2b06614 into pytorch:main Oct 6, 2021
@batermj
Copy link

batermj commented Oct 8, 2021

As a result, where is the working BERT example provided in pytorch repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants