added bAbI dataset #286
Merged
added bAbI dataset #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zshihang
force-pushed
the
master
branch
2 times, most recently
from
a87976a
to
f6799a9
Compare
because the opener built by urllib.request.build_opener() is unable to change the header of http packet by using opener.addheaders on python2.7, decide to use requests instead.
|
Is this bAbI-1k or bAbI-10k? |
|
both. there is a bool argument called |
|
Hi there, I think you forgot to reverse the story for bAbI. See here where the story is reversed for restricting to the latest sentences within memory_size but are never reversed back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are three things in this PR:
enhanced build_vocab on three dimensional data input, for example, the story in shape of [batch_size, memory_size, seq_len] of bAbI dataset. build_vocab on multi-dimension data? #264
added Facebook bAbI dataset and its test file
changed urllib to requests for downloading bAbI dataset.