additions to download_from_url and extract_archive #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port for .zip extensions in extract archive
|
You can use flake8 and run the lint error tests locally. |
| with self.assertRaises(NotImplementedError): | ||
| utils.extract_archive(archive_path) | ||
|
|
||
| # remove file |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
zhangguanheng66
requested changes
Oct 2, 2019
There was a problem hiding this comment.
In python2, exist_ok arguments doesn't exist in makedirs() func. If you really need it, you can check the python version (example here)
zhangguanheng66
approved these changes
Oct 2, 2019
|
@bentrevett Thanks for the contributions. Nice jobs. I just update the PR with the master branch. Will merge it after CI tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download_from_urlwould always fail to download from a non-google drive link due to aKeyError: 'content-disposition'from this line. This was fixed by explicitly getting the filename from the url instead of the url header.This fixed caused some issues where google drive links thought end of the url was the filename, so this is handled by setting the filename back to
Noneafter checking if the url is or isn't a google drive link.I also added support for .zip files in
extract_archive. This involved removing thearchiveargument and having the function get it from the end of the filename. Had a quick look but this didn't seem to break any functionality.Also, the
download_extract.pyfile did not seem to work in the first place. It would try and do anos.path.split(path)onvalidation.tar.gzand thenrootwould just be an empty string which would cause an error, changing the default to./validation.tar.gzseems to fix that, but I am not 100% sure this is the intended functionality.