Improve error message when extension is not found #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchtext/__init__.py
Outdated
| @@ -32,7 +32,7 @@ def _init_extension(): | |||
| extfinder = importlib.machinery.FileFinder(lib_dir, loader_details) | |||
| ext_specs = extfinder.find_spec("_torchtext") | |||
| if ext_specs is None: | |||
| raise ImportError | |||
| raise ImportError("Extension _torchtext is not found.") | |||
There was a problem hiding this comment.
Should we be more explicit for the error message?
There was a problem hiding this comment.
I am open to your suggestion, but if the extension is not found then it most likely means that there is something wrong with installation so I am not sure what is a better message to give out.
While I was working on building torchtext on fbcode, I encountered this and raising bare ImportError without a message was more confusing because I could not tell which module is causing ImportError. so as long as it is clear that it's coming from torchtext, I am okay with any message.
There was a problem hiding this comment.
How about "cpp extension is not found"? something similar.
zhangguanheng66
approved these changes
May 27, 2020
|
Rebased to see the effect of #796 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.