[inductor] Small fixes for huggingface models #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimel
approved these changes
Aug 8, 2022
desertfire
reviewed
Aug 8, 2022
| @@ -11,6 +12,8 @@ | |||
|
|
|||
| from .virtualized import V | |||
|
|
|||
| log = logging.getLogger(__name__) | |||
There was a problem hiding this comment.
Used logging and removed for this PR?
There was a problem hiding this comment.
Yeah, I think it is fine to leave this line for the future though.
desertfire
approved these changes
Aug 8, 2022
Closed
ngimel
reviewed
Aug 8, 2022
| if isinstance(device_or_dtype, torch.dtype): | ||
| return to_dtype(x, device_or_dtype) | ||
| if isinstance(device_or_dtype, torch.device): | ||
| return to_device(x, device_or_dtype) | ||
| if device is not None: | ||
| return to_device(x, device) |
There was a problem hiding this comment.
this will be wrong if both device and dtype is specified?
There was a problem hiding this comment.
Good catch, will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.