Add VBE KJT support to EmbeddingCollection #2047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
May 28, 2024
Summary: - pad lengths to final batch size so that EC with index dedup will be compatible with VBE kjt. - expands reindexed embeddings with vbe inverse indices - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
60e435c
to
3782729
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
May 28, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
3782729
to
cb47e29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
May 28, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
cb47e29
to
426d7e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
May 30, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
426d7e1
to
3b237cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
May 30, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
3b237cd
to
7ca3677
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Jun 3, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
7ca3677
to
45dc9c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Jun 4, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
joshuadeng
force-pushed
the
export-D51600051
branch
from
45dc9c3
to
1d46d90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
force-pushed
the
export-D51600051
branch
from
1d46d90
to
e741ffa
Compare
joshuadeng
added a commit
to joshuadeng/torchrec
that referenced
this pull request
Jun 6, 2024
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: Pull Request resolved: pytorch#2047 - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Reviewed By: dstaay-fb Differential Revision: D51600051
|
This pull request was exported from Phabricator. Differential Revision: D51600051 |
joshuadeng
force-pushed
the
export-D51600051
branch
from
e741ffa
to
6255a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D51600051