-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VBE KJT support to EmbeddingCollection #2047
Conversation
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad lengths to final batch size so that EC with index dedup will be compatible with VBE kjt. - expands reindexed embeddings with vbe inverse indices - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
60e435c
to
3782729
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
3782729
to
cb47e29
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
cb47e29
to
426d7e1
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
426d7e1
to
3b237cd
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
3b237cd
to
7ca3677
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
7ca3677
to
45dc9c3
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
45dc9c3
to
1d46d90
Compare
This pull request was exported from Phabricator. Differential Revision: D51600051 |
1d46d90
to
e741ffa
Compare
Summary: - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Differential Revision: D51600051
This pull request was exported from Phabricator. Differential Revision: D51600051 |
Summary: Pull Request resolved: pytorch#2047 - pad VBE kjt lengths to final batch size so that it's compatible with EC kernel. - works with index dedup - expands embeddings with vbe inverse indices - remove sync from keyed jagged index select for permute - long term solution is to fix seq TBE to not need lengths/batch size info, just length per key Reviewed By: dstaay-fb Differential Revision: D51600051
This pull request was exported from Phabricator. Differential Revision: D51600051 |
e741ffa
to
6255a2e
Compare
Summary:
Differential Revision: D51600051