Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ax_multiobjective_nas_tutorial.py is failing against 1.13 #2090

Closed
svekars opened this issue Oct 20, 2022 · 5 comments
Closed

ax_multiobjective_nas_tutorial.py is failing against 1.13 #2090

svekars opened this issue Oct 20, 2022 · 5 comments
Labels
1.13

Comments

@svekars
Copy link
Contributor

svekars commented Oct 20, 2022

ax_multiobjective_nas_tutorial.py is failing against 1.13 binaries. More details here.

We will disable this tutorial until this issue is resolved.

cc: @Balandat @malfet
@svekars svekars added the 1.13 label Oct 20, 2022
@Balandat
Copy link
Contributor

Thanks for the heads up.

This seems to be an issue with TorchX which appears to fail on import? @d4l3k are there known incompatibilities between torchx and torch 1.13 (looks like the torchx version installed in CI is 0.2.0).

@Balandat
Copy link
Contributor

cc @dme65, @esantorella

@d4l3k
Copy link
Contributor

d4l3k commented Oct 20, 2022

The issue isn't TorchX or torch 1.13 -- importlib_metadata broke backwards compatibility with Python 3.7

python/importlib_metadata#411

We've had to pin <5.0 in trunk https://github.com/pytorch/torchx/blob/main/dev-requirements.txt#L10 to resolve the issue

@Balandat
Copy link
Contributor

Great, thanks for the quick response. Let me put up a PR to add that pin also to the reqs for the tutorials.

Balandat added a commit to Balandat/tutorials that referenced this issue Oct 20, 2022
@Balandat
Pin importlib_metadata<5.0 in requirements.txt
cc1e40e 
v5.0.0 causes issues with python 3.7: python/importlib_metadata#411

This was raised in the context of pytorch#2090

This PR pins the version to <5.0 to circumvent this. Maybe a better fix would be to bump the python version in CI to 3.8, but that's something to discuss more broadly.
@Balandat Balandat mentioned this issue Oct 20, 2022
Merged
@Balandat
Copy link
Contributor

@svekars I merged the fix, I assume this can be closed? Or is there anything that needs to be done to re-enable the tutorial?

@svekars svekars closed this as completed Mar 1, 2023
@ekurtgl ekurtgl mentioned this issue Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.13
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@d4l3k @Balandat @svekars