Pin importlib_metadata<5.0 in requirements.txt #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v5.0.0 causes issues with python 3.7: python/importlib_metadata#411 This was raised in the context of pytorch#2090 This PR pins the version to <5.0 to circumvent this. Maybe a better fix would be to bump the python version in CI to 3.8, but that's something to discuss more broadly.
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@malfet any objections? |
svekars
pushed a commit
that referenced
this pull request
Oct 21, 2022
v5.0.0 causes issues with python 3.7: python/importlib_metadata#411
facebook-github-bot
pushed a commit
to pytorch/torchx
that referenced
this pull request
Oct 21, 2022
Summary: importlib.metadata in 3.12 breaks compatibility with the dict style interface. This switches TorchX to use importlib_metadata for all versions and switches the code to use the 3.10+ select style interface instead of dict. This avoids having to pin importlib_metadata<5 such as in pytorch/tutorials#2091 Pull Request resolved: #623 Test Plan: Unit tests on both importlib_metadata 5.0 and 4.1.3 Reviewed By: priyaramani Differential Revision: D40561638 Pulled By: d4l3k fbshipit-source-id: 95144406c0e3dcbe203ada3ff3236f7384ab2a5c
vkuzo
added a commit
that referenced
this pull request
Oct 22, 2022
* update NS for FX tutorial for PyTorch v1.13 Summary: Makes a couple of updates to ensure this tutorial still runs on 1.13: 1. changes the `qconfig_dict` argument of `prepare_fx` to `qconfig_mapping` 2. adds `example_inputs` to `prepare_fx` Test plan: Run the tutorial, it runs without errors on master * Pin importlib_metadata<5.0 for python <= 3.7 in requirements.txt (#2091) v5.0.0 causes issues with python 3.7: python/importlib_metadata#411 * Enable the FX tutorial Co-authored-by: Max Balandat <Balandat@users.noreply.github.com> Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.0.0 causes issues with python 3.7: python/importlib_metadata#411
This was raised in the context of #2090
This PR pins the version to <5.0 to circumvent this. Maybe a better fix would be to bump the python version in CI to 3.8, but that's something to discuss more broadly.