Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for detection model to test input list unmodified #1085

Merged
merged 2 commits into from Jul 4, 2019

Conversation

buoyancy99
Copy link
Contributor

This PR is upon the request for such test in #1084

Update test for detection model to test input list unmodified according to suggestion in a previous PR
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I've kicked the CI again, once tests pass this is good to merge!

@fmassa
Copy link
Member

fmassa commented Jul 4, 2019

@buoyancy99 test failures are real, can you use instead assertTrue(tensor1.equal(tensor2)?

@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #1085 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   64.66%   64.67%   +<.01%     
==========================================
  Files          68       68              
  Lines        5406     5407       +1     
  Branches      829      829              
==========================================
+ Hits         3496     3497       +1     
  Misses       1661     1661              
  Partials      249      249
Impacted Files Coverage Δ
torchvision/models/vgg.py 89.55% <0%> (ø) ⬆️
torchvision/models/resnet.py 88.27% <0%> (ø) ⬆️
torchvision/models/detection/transform.py 78.3% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8cc19...232afc5. Read the comment docs.

@fmassa fmassa merged commit d762537 into pytorch:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants