Set allow_redefinition = True for mypy #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
requested changes
Oct 4, 2021
There was a problem hiding this comment.
Changing status, since mypy complains in a few cases: https://app.circleci.com/pipelines/github/pytorch/vision/10955/workflows/c429be0a-5801-4fc3-b218-ac32096e5cf5/jobs/840748
|
This would heavily help #4220 |
|
If anyone is keen on fixing the mypy errors, please feel free to go ahead :) |
|
Will do tomorrow |
This was referenced Oct 5, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Summary: * Allow redefinition for mypy * appease mypy Reviewed By: NicolasHug Differential Revision: D31505572 fbshipit-source-id: 718742dccd5e4d087ac3f9ec5f9a0b71ba91313c Co-authored-by: Philip Meier <github.pmeier@posteo.de>
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
* Allow redefinition for mypy * appease mypy Co-authored-by: Philip Meier <github.pmeier@posteo.de>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Allow redefinition for mypy * appease mypy Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully help avoid making mypy too unhappy with basic stuff like #4527 (comment)