[proto] Added some transformations and fixed type hints #6245
Conversation
|
|
||
| def _get_params(self, sample: Any) -> Dict[str, Any]: | ||
| # vfdev-5: techically, this op can work on bboxes/segm masks only inputs without image in samples | ||
| # What if we have multiple images/bboxes/masks of different sizes ? | ||
| # TODO: let's support bbox or mask in samples without image |
There was a problem hiding this comment.
Correct. This logic was added before you land kernels for handling crops BBoxes and masks. Now we can review this transform. It's worth noting that passing bboxes or masks without image doesn't make a lot of sense in practice because this will cause desyncing between the image and the targets. This is something that was brought up many times as a potential feature (passing only bboxes) but so far we haven't found a compelling example on where this can be used in practice. Happy to review this if we do, but for now we can assume that an image (or video coming up) will be available to give us access to the width/height here.
There was a problem hiding this comment.
Not a practical use-case, but we can't test this transform on bboxes/masks without an image :)
There was a problem hiding this comment.
I'm curious to see if this creates issues such as having no access to specific meta-data you would need from the image. If you can do this without them, we can chat adding it. But if you have to add lots of workarounds to support it, we should find a real-world use-case. I think the test use-case can be achieved by passing an equivalent image.
Updated code according to the review
…nto proto-transforms-api-p3
Go back with if-return/elif-return/else-return
vfdev-5
force-pushed
the
proto-transforms-api-p3
branch
from
a16e61d
to
42b4bf3
Compare
vfdev-5
force-pushed
the
proto-transforms-api-p3
branch
from
883a525
to
12adbe8
Compare
|
I'll merge this PR to main and then work with proto-transforms-api branch |
|
Hey @vfdev-5! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * Another attempt to add transforms * Fixed padding type hint * Fixed fill arg for pad and rotate, affine * code formatting and type hints for affine transformation * Fixed flake8 * Updated tests to save and load transforms * Fixed code formatting issue * Fixed jit loading issue * Restored fill default value to None Updated code according to the review * Added tests for rotation, affine and zoom transforms * Put back commented code * Random erase bypass boxes and masks Go back with if-return/elif-return/else-return * Fixed acceptable and non-acceptable types for Cutmix/Mixup * Updated conditions for _BaseMixupCutmix Reviewed By: jdsgomes Differential Revision: D37993418 fbshipit-source-id: 900faa217ce7cc0297eaa62671fe0518e8b4bc83
Description:
paddingarg type hintfillarg type hintChangedfillarg type hint, default from None to 0