[jit] Updated tests checking save and load transforms #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @vfdev-5
Just a minor note, in the future it might be preferable to do that kind of formatting in a separate PR, so that we can add the entry to https://github.com/pytorch/vision/blob/main/.git-blame-ignore-revs in order to keep |
|
@NicolasHug thanks, sounds good! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
Summary: * Updated tests to save and load transforms * Fixed code formatting issue Reviewed By: jdsgomes Differential Revision: D37993421 fbshipit-source-id: 7e3314ba14741821c1858186388e0342c6971fbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If we change type hints, jit can fail only on loading scripted saved transform. Such error was only caught accidentally by a CI job building gallery example for the PR with type hint change: #6245.
In this PR let's add loading pass for a saved transform.
Additionally, I fixed code formatting to reduce the number of lines.