Cleanup prototype datasets CI and related things #6944
Conversation
| @@ -152,15 +152,6 @@ commands: | |||
| args: --no-build-isolation <<# parameters.editable >> --editable <</ parameters.editable >> . | |||
| descr: Install torchvision <<# parameters.editable >> in editable mode <</ parameters.editable >> | |||
|
|
|||
| install_prototype_dependencies: | |||
There was a problem hiding this comment.
thanks Philip, Do you mind just leaving that one last time, to make sure CI is still green with the new changes (and then we can remove it in this PR)
There was a problem hiding this comment.
You commented on the CircleCi config, but these test continue to run. We only removed the dependencies there. You meant that I should run the datasets tests again, right?
There was a problem hiding this comment.
I've temporarily reinstated the prototype datasets CI in 215fb18. LMK if that is not what you wanted.
There was a problem hiding this comment.
CI is red, but for an unrelated failure on the transforms tests. Datasets tests are green.
There was a problem hiding this comment.
Thanks Philip
I see some prototype failures in the [REVERT ME] diff that aren't present in the latest one. I assume they were fixed in-between in #6934 ? If that's the case, LGTM. Thanks!
Summary: * remove prototype datasets from CI * move encoded features to prototype datasets namespace * remove decoding transforms * [REVERT ME] reinstate prototype datasets CI * Revert "[REVERT ME] reinstate prototype datasets CI" This reverts commit 215fb18. Reviewed By: NicolasHug Differential Revision: D41265183 fbshipit-source-id: 0ad525314ac72aa784cd329fa17e9776b42bba46
As sad as it is, this PR does three things:
features.Encoded*into thetorchvision.prototype.datasetsnamespace, since they are only used there.cc @seemethere @bjuncek