Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix documentation of _get_inverse_affine_matrix #6947

Merged
merged 2 commits into from
Nov 15, 2022
Merged

fix documentation of _get_inverse_affine_matrix #6947

merged 2 commits into from
Nov 15, 2022

Conversation

yokosyun
Copy link
Contributor

fix affine documentation

implementation seems fine, however documentation doesn't match

c = math.sin(rot - sy) / math.cos(sy)

datumbox
datumbox approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox
Copy link
Contributor

@yokosyun Thanks for the fix. Note that I can't merge this until the CLA is signed. Not sure why the bot hasn't commented on the thread. You can do this using this link. Let me know if you face any problems.

@facebook-github-bot
Copy link

Hi @yokosyun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@yokosyun
Copy link
Contributor Author

@datumbox
thank you for helping me. I think I could register for it

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@datumbox datumbox merged commit ad128b7 into pytorch:main Nov 15, 2022
facebook-github-bot pushed a commit that referenced this pull request Nov 19, 2022
@facebook-github-bot
[fbsync] fix documentation of _get_inverse_affine_matrix (#6947)
a855b97 
Reviewed By: YosuaMichael

Differential Revision: D41376281

fbshipit-source-id: 7a83cc890ce7751e75f13c2bd5b72359a8074d70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yokosyun @datumbox @facebook-github-bot