add usage logging to prototype dispatchers / kernels #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
Reviewed By: datumbox Differential Revision: D41836890 fbshipit-source-id: bc3cf1b53fba33beaac82fa5ba5f289b8839e84d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, logging is added to the dispatcher like transforms v1 does. Two kernels,
clamp_bounding_boxandconvert_format_bounding_box, don't have a dispatcher, so I added the logging directly to them.This PR also adds tests that enforces logging on dispatchers and the option to enforce it for kernels.
cc @vfdev-5 @datumbox @bjuncek