Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for bounding boxes #7276

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Add more tests for bounding boxes #7276

merged 6 commits into from
Feb 17, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 17, 2023 •
edited by pytorch-bot bot
Loading

  1. Add a test to our functional dispatchers that enforces that the format is not changed.
  2. Expand the transforms smoke test to ensure that degenerate boxes stay degenerate.

cc @vfdev-5 @bjuncek

pmeier
pmeier commented Feb 17, 2023
View reviewed changes
test/test_prototype_transforms_functional.py
[
info
for info in DISPATCHER_INFOS
if datapoints.BoundingBox in info.kernels and info.dispatcher is not F.convert_format_bounding_box
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to exclude F.convert_format_bounding_box since its only job is to change the format.

test/test_prototype_transforms.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM, I'll approve now to unblock. As discussed offline, let's add the same test_bounding_box_format_consistency at the transforms level

test/test_prototype_transforms.py Outdated Show resolved Hide resolved
@NicolasHug NicolasHug mentioned this pull request Feb 17, 2023
Closed
49 tasks
@pmeier pmeier merged commit 56b0497 into pytorch:main Feb 17, 2023
@pmeier pmeier deleted the bbox-tests branch February 17, 2023 12:31
facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2023
@NicolasHug @facebook-github-bot
[fbsync] Add more tests for bounding boxes (#7276)
d68bf8b 
Reviewed By: vmoens

Differential Revision: D44416622

fbshipit-source-id: 228ffae17032ab3d1d47c24f4bed0a84b4d17a0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: tests module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot