Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXX_STANDARD 14 -> 17 #7608

Merged
merged 2 commits into from
May 22, 2023
Merged

CXX_STANDARD 14 -> 17 #7608

merged 2 commits into from
May 22, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 20, 2023

pytorch/pytorch#100557 migrated some more or the final components from C++14 to C++17. We attempted the same in #7116, but missed

  • the C++ example
  • the tracing test
  • the Android and iOS builds

This leads to CI breakages, e.g. https://app.circleci.com/pipelines/github/pytorch/vision/24791/workflows/6eba1fff-1d2b-4eac-8436-335791f52a7d/jobs/1867076

@pytorch-bot
Copy link

pytorch-bot bot commented May 20, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7608

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit c095522:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip

@pmeier pmeier merged commit 508bc1d into pytorch:main May 22, 2023
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the cxx-14-17 branch May 22, 2023 13:25
facebook-github-bot pushed a commit that referenced this pull request May 23, 2023
Reviewed By: vmoens

Differential Revision: D46071413

fbshipit-source-id: 852549a52847c8146b841625053d637478b10934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants