-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Caltech101, Caltech256, and CelebA #775
Conversation
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 40.99% 38.13% -2.86%
==========================================
Files 29 32 +3
Lines 2747 3126 +379
Branches 432 487 +55
==========================================
+ Hits 1126 1192 +66
- Misses 1542 1855 +313
Partials 79 79
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for the PR and sorry for the delay in reviewing it.
It generally looks good, I have a few comments.
Also, in a more general question: is Caltech101 and Caltech256 still used for papers nowadays? If I remember properly, you could get very good classification results by just classifying on the average color in the image.
I think all of the issues should be resolved now. I don't think many papers only use Caltech101/256, but I've seen it used for domain adaptation experiments in somewhat recent papers, such as http://papers.nips.cc/paper/6757-learning-multiple-tasks-with-deep-relationship-networks (2017), along with a few papers that it cites. Do you think some of those (Office-Home and ImageCLEF) are worth including? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks almost ready to be merged, thanks!
I have only a few minor nits about using a legacy torch.LongTensor
construct, otherwise this is good to be merged
I haven't myself seen / used Office-Home and ImageCLEF be used much, but if you think it would be valuable to have them in torchvision, if you could send a PR adding them it would be great |
Last comment is resolved now. I'll think about whether those two are worth including. |
Separate PRs are better I think. Thanks! |
No description provided.