Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docstring of CelebA regarding arrays #7161

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 1, 2023

Although the OP originally envisioned to return np.array's in #775 over the course of the review the return type was changed to plain tensors: #775 (comment) The docstring was forgotten.

Meaning, although the docstring stated that we return np.array's, we always have returned torch.Tensor's. Thus, this PR just fixes the docstring to align with the behavior.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks Philip

@pmeier pmeier merged commit cb8c441 into pytorch:main Feb 2, 2023
@pmeier pmeier deleted the celeba-docstring branch February 2, 2023 09:44
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier added the bug label Feb 2, 2023
facebook-github-bot pushed a commit that referenced this pull request Feb 9, 2023
Reviewed By: vmoens

Differential Revision: D43116125

fbshipit-source-id: af098f1e12fc0b68c7e06df20e6deb54a1e64fab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants