Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup v2 tests #7812

Merged
merged 2 commits into from
Aug 9, 2023
Merged

cleanup v2 tests #7812

merged 2 commits into from
Aug 9, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 9, 2023 •
edited by pytorch-bot bot
Loading

Acts on

vision/test/test_transforms_v2_refactored.py

Lines 178 to 179 in 8faa1b1

# TODO: remove this parameter
kernel,

cc @vfdev-5

@pmeier pmeier requested a review from NicolasHug August 9, 2023 08:24
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7812

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures

As of commit 7e15079:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier

@pmeier pmeier merged commit 6b02079 into pytorch:main Aug 9, 2023
10 of 23 checks passed
@NicolasHug NicolasHug mentioned this pull request Aug 9, 2023
Merged
@pmeier pmeier deleted the cleanup-v2-tests branch August 10, 2023 09:09
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
@NicolasHug @facebook-github-bot
[fbsync] cleanup v2 tests (#7812)
121f472 
Reviewed By: matteobettini

Differential Revision: D48642252

fbshipit-source-id: 80bfb6c9ccc749ffdded762959b32617739821db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: tests module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot