Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo torchscript example #7889

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Redo torchscript example #7889

merged 5 commits into from
Aug 29, 2023

Conversation

NicolasHug
Copy link
Member

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7889

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 8057bc7 with merge base 6472a5c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:07 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:08 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:09 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:09 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 16:09 — with GitHub Actions Inactive
NicolasHug
NicolasHug commented Aug 25, 2023
View reviewed changes
gallery/transforms/plot_torchscript_support.py Outdated
Comment on lines 71 to 72
# Below we now show how to combine image transformations and a model forward
# pass, while using ``torch.jit.script`` to obtain a single scripted module.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a quick re-write and I didn't give this the same attention as the other examples. After 1+ week of writing docs I don't have much mental space left to dedicate to this. In particular, I didn't change anything to the text below. So if you have comments about it, and since everything below is pre-existing, I suggest to follow-up in other PRs if needed.

NicolasHug
NicolasHug commented Aug 25, 2023
View reviewed changes
gallery/transforms/plot_transforms_getting_started.py
@@ -172,6 +172,7 @@
# Re-using the transforms and definitions from above.
out_img, out_target = transforms(img, target)

# sphinx_gallery_thumbnail_number = 4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by

@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 17:11 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 17:11 — with GitHub Actions Inactive
pmeier
pmeier approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nicolas! Just noting here that placing this into the "transforms" section might not be the best fit. While containing some transforms, the latter part of the tutorial mainly deals with the whole pipeline and the predictions. Since the only use of v2 is inside the warning, I would also be ok with leaving this gallery in the "others" section. Up to you.

@NicolasHug
Copy link
Member Author

Since the only use of v2 is inside the warning, I would also be ok with leaving this gallery in the "others" section

OK, I'll put it back where it was and keep its original name to preserve the html links. I'll keep the new title.

@NicolasHug NicolasHug merged commit 655ebdb into pytorch:main Aug 29, 2023
56 of 63 checks passed
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@NicolasHug @facebook-github-bot
[fbsync] Redo torchscript example (#7889)
c458b62 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900398

fbshipit-source-id: 66331de8d66c93aab1e91b154a5ce29371299b9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @pmeier @facebook-github-bot