port tests for F.resized_crop and RandomResizedCrop #7934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7934
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use ❌ 2 New Failures, 8 Unrelated FailuresAs of commit 9c0667b with merge base 4103552 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Sep 6, 2023
| @@ -526,88 +525,6 @@ def test_tv_tensor_explicit_metadata(self, metadata): | |||
| # `transforms_v2_kernel_infos.py` | |||
|
|
|||
|
|
|||
| def _compute_affine_matrix(angle_, translate_, scale_, shear_, center_): | |||
There was a problem hiding this comment.
Driveby. This was not used anywhere anymore.
|
|
||
|
|
||
| @pytest.mark.parametrize("device", cpu_and_cuda()) | ||
| def test_correctness_vertical_flip_segmentation_mask_on_fixed_input(device): |
There was a problem hiding this comment.
Driveby. We forgot to remove this when porting the tests for F.vertical_flip.
NicolasHug
approved these changes
Sep 6, 2023
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
Reviewed By: matteobettini Differential Revision: D49600789 fbshipit-source-id: 9b6f99504819434be8e00913cea62cd29159a98f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a composite kernel, I refrained from large parametrizations. LMK if you want more.
cc @vfdev-5